Test: cts: Add cts-lab --nic option used for generated IP address resources#3982
Conversation
…ources More distributions are using systemd's network device naming schemes: https://www.freedesktop.org/software/systemd/man/latest/systemd.net-naming-scheme.html In that case, eth0 is no longer the default interface name.
| help="Offset for generated IP address resources") | ||
| grp2.add_argument("--nic", | ||
| default="eth0", | ||
| help="Network interface used for generated IP address resources") |
There was a problem hiding this comment.
We should note that this applies only if --ip is set to an IPv6 address.
Alternatively, we could modify cib.py so that it applies to both IPv4 and IPv6 base addresses.
As a side note, I'm not sure that explicitly setting a nic parameter is required anymore for IPv6, in most cases. It looks like the IPaddr2 resource agent should be able to find the correct interface via its findif.sh helper. For example:
IPv6 support in IPaddr2 was probably less mature (or perhaps nonexistent) when CTS lab was written.
There was a problem hiding this comment.
We should note that this applies only if
--ipis set to an IPv6 address.Alternatively, we could modify
cib.pyso that it applies to both IPv4 and IPv6 base addresses.
Makes sense. The latter sounds better to me.
As a side note, I'm not sure that explicitly setting a
nicparameter is required anymore for IPv6, in most cases. It looks like theIPaddr2resource agent should be able to find the correct interface via itsfindif.shhelper.
I assume so. But nic parameter is anyway mandatory for a link local address:
, such as the ones by defaulting --ip.
There was a problem hiding this comment.
We might want something like: #3986
I'll have to test it tomorrow though.
More distributions are using systemd's network device naming schemes: https://www.freedesktop.org/software/systemd/man/latest/systemd.net-naming-scheme.html
In that case, eth0 is no longer the default interface name.